Ability to revoke lease #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MohdAhmad @jonboulle PTAL |
| @@ -209,6 +211,21 @@ func (esr *etcdSubnetRegistry) watchSubnets(ctx context.Context, network string, | |||
| return evt, e.Node.ModifiedIndex, err | |||
| } | |||
|
|
|||
| func (esr *etcdSubnetRegistry) watchSubnet(ctx context.Context, network string, since uint64, sn ip.IP4Net) (Event, uint64, error) { | |||
| key := path.Join(esr.etcdCfg.Prefix, "subnets", network, sn.StringSep(".", "-")) | |||
There was a problem hiding this comment.
Need to swap 'network' and 'subnets' here.
|
Overall LGTM |
This adds an ability to revoke a lease by deleting it from etcd. A corresponding API for server case is also added. Once the lease is revoked, flannel will just acquire a new one. This has limited use today but is part of flannel-io#280 to add reservations. With reservations, there will be a mode to not acquire a lease if a reservation was not found.
eyakubovich
force-pushed
the
revoke-lease
branch
from
02117e7 to
6ab6edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an ability to revoke a lease by deleting it
from etcd. A corresponding API for server case is also added.
Once the lease is revoked, flannel will just acquire a new
one. This has limited use today but is part of #280 to
add reservations. With reservations, there will be a mode
to not acquire a lease if a reservation was not found.