return proper error on callBundle incorrect gasPrice #141

TymKh · 2024-01-30T16:25:16Z

📝 Summary

📚 References

I have seen and agree to CONTRIBUTING.md

…ad can easily fail for payloads not constructed via analogous fcu

This change refactors stacktrie to separate the stacktrie itself from the internal representation of nodes: a stacktrie is not a recursive structure of stacktries, rather, a framework for representing and operating upon a set of nodes. --------- Co-authored-by: Gary Rong <[email protected]>

fixes various typos in core

* eth/ethconfig: fix typo on comment * params/config: fix typo on comment * eth/ethconfig: fix typo on comment

This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes but moves (and renames) the light.NodeSet

* fix a typo * trie: additional fixes to docstrings --------- Co-authored-by: Martin Holst Swende <[email protected]>

…ocol (#28261) * eth: enforce announcement metadatas and drop peers violating the protocol * eth/fetcher: relax eth/68 validation a bit for flakey clients * tests/fuzzers/txfetcher: pull in suggestion from Marius * eth/fetcher: add tests for peer dropping * eth/fetcher: linter linter linter linter linter

…s limits (#28280)

This change - Removes the owner-notion from a stacktrie; the owner is only ever needed for comitting to the database, but the commit-function, the `writeFn` is provided by the caller, so the caller can just set the owner into the `writeFn` instead of having it passed through the stacktrie. - Removes the `encoding.BinaryMarshaler`/`encoding.BinaryUnmarshaler` interface from stacktrie. We're not using it, and it is doubtful whether anyone downstream is either.

* eth/fetcher: throttle tx fetches to 128KB responses * eth/fetcher: unindent a clause per review request

* cmd, core: resolve scheme from a read-write database * cmd, core, eth: move the scheme check in the ethereum constructor * cmd/geth: dump should in ro mode * cmd: reverts

…306) This change addresses an issue in snap sync, specifically when the entire sync process can be halted due to an encountered empty storage range. Currently, on the snap sync client side, the response to an empty (partial) storage range is discarded as a non-delivery. However, this response can be a valid response, when the particular range requested does not contain any slots. For instance, consider a large contract where the entire key space is divided into 16 chunks, and there are no available slots in the last chunk [0xf] -> [end]. When the node receives a request for this particular range, the response includes: The proof with origin [0xf] A nil storage slot set If we simply discard this response, the finalization of the last range will be skipped, halting the entire sync process indefinitely. The test case TestSyncWithUnevenStorage can reproduce the scenario described above. In addition, this change also defines the common variables MaxAddress and MaxHash.

This PR schedules the cancun fork for the goerli testnet as discussed on ACD. Spec: ethereum/execution-specs#860 We schedule: goerli at 1705473120

When managing geth, it is sometimes desirable to do a partial wipe; deleting state but retaining freezer data. A partial wipe can be somewhat tricky to accomplish. This change implements the ability to perform partial wipe by making it possible to run geth removedb non-interactive, using command line options instead.

update logger test data

This is a rewrite of the 'simulated backend', an implementation of the ethclient interfaces which is backed by a simulated blockchain. It was getting annoying to maintain the old version of the simulated backend feature because there was a lot of code duplication with the main client. The new version is built using parts that we already have: an in-memory geth node instance running in developer mode provides the chain, while the Go API is provided by ethclient. A backwards-compatibility wrapper is provided, but the simulated backend has also moved to a more sensible import path: github.com/ethereum/go-ethereum/ethclient/simulated --------- Co-authored-by: Felix Lange <[email protected]> Co-authored-by: Gary Rong <[email protected]>

dvush · 2024-01-30T17:32:27Z

internal/ethapi/api.go

@@ -2385,7 +2385,7 @@ func (s *BundleAPI) CallBundle(ctx context.Context, args CallBundleArgs) (map[st
 		}
 		uint256GasPrice, ok := uint256.FromBig(gasPrice)
 		if !ok {
-			return nil, fmt.Errorf("err: %w; txhash %s", err, tx.Hash())


I feel like someone can depend on this particular message struct.

Is it possible to not change it?

what if:

return nil, fmt.Errorf("err: incorrect gasPrice; txhash %s", tx.Hash())

ok, as I undestood this is the code path that was added for deneb so no need to make this compatible

TymKh · 2024-02-07T16:21:21Z

problem was actually deeper than this, I pushed another fix

lightclient and others added 30 commits October 4, 2023 15:27

eth/catalyst: fix parent beacon block test

fd8a58d

eth/catalyst: support new payload v1 in v2 again

4093991

eth/catalyst: simplify new payload param checks

fa574ad

beacon/engine,eth/catalyst,miner: prefix payload ID so that get paylo…

53766a6

…ad can easily fail for payloads not constructed via analogous fcu

beacon/engine,eth/catalyst: gate on get payload on id version

280891b

beacon/engine: add docs for payload version type

6e6c723

Merge remote-tracking branch 'lightclient/devnet-9' into deneb

0c61e52

don't resolve txs until necessary

2469cdf

core/txpool/legacypool: fix typo (#28258)

4e1e373

check for nil tx on resolve

bde2f8c

blob bundle fixes

4c974fe

core: fix typos (#28255)

fa6107c

fixes various typos in core

eth, params: fix typos (#28286)

db9afae

* eth/ethconfig: fix typo on comment * params/config: fix typo on comment * eth/ethconfig: fix typo on comment

all: move light.NodeSet to trienode.ProofSet (#28287)

6b1e4f4

This is a minor refactor in preparation of changes to range verifier. This PR contains no intentional functional changes but moves (and renames) the light.NodeSet

trie: fix a typo, use correct docstrings (#28302)

6505297

* fix a typo * trie: additional fixes to docstrings --------- Co-authored-by: Martin Holst Swende <[email protected]>

git: ignore tests/spec-tests folder (#28254)

5e43ed0

accounts/abi/bind/backend: use requested header for gas prices and ga…

2c007cf

…s limits (#28280)

ethdb/pebble: add level file metrics (#28271)

7776a32

eth/fetcher: throttle tx fetches to 128KB responses (#28304)

a6deb2d

* eth/fetcher: throttle tx fetches to 128KB responses * eth/fetcher: unindent a clause per review request

eth/fetcher: fix typo

13d1d42

cmd, core: resolve scheme from a read-write database (#28313)

eeb5dc3

* cmd, core: resolve scheme from a read-write database * cmd, core, eth: move the scheme check in the ethereum constructor * cmd/geth: dump should in ro mode * cmd: reverts

accounts, cmd: fix typos (#28300)

0004c6b

cmd/geth: fix failing test (#28322)

d2c0bed

params: release Geth v.1.13.3

0d45d72

params: begin v1.13.4 release cycle

2f66d7c

go.mod, internal/build: update Azure dependencies (#28329)

1f30cae

vuittont60 and others added 14 commits January 8, 2024 20:31

cmd/devp2p/internal/ethtest: fix typos in comments (#28772)

f29520f

params, core/forkid: schedule cancun fork on goerli (#28719)

cfff3cb

This PR schedules the cancun fork for the goerli testnet as discussed on ACD. Spec: ethereum/execution-specs#860 We schedule: goerli at 1705473120

accounts/abi: fix bigInt topic encoding (#28764)

d0edc5a

cmd/geth: update log test data (#28780)

9e018ce

update logger test data

params: go-ethereum v1.13.9 stable

4f82531

Merge branch 'master' into release/1.13

dd938d1

params: begin v1.13.10 release cycle

daa2e5d

version: release v1.13.10 to fix bad tag

a162091

Merge branch 'master' into release/1.13

bc0be1b

Merge tag 'v1.13.10' into deneb

56cf382

set head in sbundle pool

ae7357b

merge v1.13.11

677a32d

TymKh requested review from dvush, Ruteri and avalonche as code owners January 30, 2024 16:25

avalonche approved these changes Jan 30, 2024

View reviewed changes

dvush reviewed Jan 30, 2024

View reviewed changes

0x416e746f6e approved these changes Jan 30, 2024

View reviewed changes

dvush approved these changes Feb 3, 2024

View reviewed changes

avalonche added 5 commits February 4, 2024 13:26

add bundle support

11f6bb0

fix tests

00bc97b

add blob fields

4d4f4df

fix logging

e50dd00

remove private txs from blobs

001c352

return proper error on callBundle incorrect gasPrice

2889978

TymKh force-pushed the fix-error-handling branch from c7deb75 to 2889978 Compare February 7, 2024 16:28

Base automatically changed from deneb to main March 12, 2024 16:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

return proper error on callBundle incorrect gasPrice #141

return proper error on callBundle incorrect gasPrice #141

TymKh commented Jan 30, 2024 •

edited

Loading

dvush Jan 30, 2024

0x416e746f6e Jan 30, 2024

dvush Feb 3, 2024

TymKh commented Feb 7, 2024

return proper error on callBundle incorrect gasPrice #141

Are you sure you want to change the base?

return proper error on callBundle incorrect gasPrice #141

Conversation

TymKh commented Jan 30, 2024 • edited Loading

📝 Summary

📚 References

dvush Jan 30, 2024

Choose a reason for hiding this comment

0x416e746f6e Jan 30, 2024

Choose a reason for hiding this comment

dvush Feb 3, 2024

Choose a reason for hiding this comment

TymKh commented Feb 7, 2024

TymKh commented Jan 30, 2024 •

edited

Loading