Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-boost-utils #488

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Upgrade go-boost-utils #488

merged 3 commits into from
Jul 28, 2023

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Jul 28, 2023

πŸ“ Summary

Upgrade relay code to the latest go-boost-utils as the library migrated to attestant types.

β›± Motivation and Context

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@avalonche avalonche requested review from metachris, michaelneuder and jtraglia and removed request for michaelneuder July 28, 2023 16:27
Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my initial review. Overall looks pretty good.

services/api/types_test.go Show resolved Hide resolved
services/api/service_test.go Outdated Show resolved Hide resolved
services/api/service_test.go Outdated Show resolved Hide resolved
services/api/service.go Show resolved Hide resolved
services/api/optimistic_test.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@avalonche avalonche force-pushed the upgrade-boost-utils branch from 7e60519 to 8547527 Compare July 28, 2023 18:20
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@f923651). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             develop     #488   +/-   ##
==========================================
  Coverage           ?   32.20%           
==========================================
  Files              ?       24           
  Lines              ?     4536           
  Branches           ?        0           
==========================================
  Hits               ?     1461           
  Misses             ?     2865           
  Partials           ?      210           
Flag Coverage Ξ”
unittests 32.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘ great work!

@avalonche avalonche mentioned this pull request Jul 28, 2023
17 tasks
@avalonche avalonche merged commit 4f04042 into develop Jul 28, 2023
@avalonche avalonche deleted the upgrade-boost-utils branch July 28, 2023 23:35
@avalonche avalonche mentioned this pull request Jul 28, 2023
3 tasks
avalonche added a commit that referenced this pull request Aug 1, 2023
* Upgrade go-boost-utils

* pr comments

* remove commented out code
avalonche added a commit that referenced this pull request Aug 2, 2023
* Upgrade go-boost-utils

* pr comments

* remove commented out code
avalonche added a commit that referenced this pull request Aug 2, 2023
* Upgrade go-boost-utils

* pr comments

* remove commented out code
avalonche added a commit that referenced this pull request Aug 15, 2023
* Upgrade go-boost-utils

* pr comments

* remove commented out code
avalonche added a commit that referenced this pull request Sep 29, 2023
* Upgrade go-boost-utils

* pr comments

* remove commented out code
avalonche added a commit that referenced this pull request Oct 31, 2023
* Upgrade go-boost-utils

* pr comments

* remove commented out code
avalonche added a commit that referenced this pull request Jan 4, 2024
* Upgrade go-boost-utils

* pr comments

* remove commented out code
avalonche added a commit that referenced this pull request Jan 19, 2024
* Upgrade go-boost-utils

* pr comments

* remove commented out code
austonst pushed a commit to aestus-relay/mev-boost-relay that referenced this pull request Jan 25, 2024
* Upgrade go-boost-utils

* pr comments

* remove commented out code
avalonche added a commit that referenced this pull request Jan 30, 2024
* Remove bellatrix from wrapper types (#475)

* Remove bellatrix from wrapper types

* remove test logs

* Remove get header wrapper types (#477)

* Remove signed blinded beacon block wrapper (#482)

* remove signed blinded beacon block wrapper type

* linting

* remove signed beacon block wrapper types (#483)

* Remove submit block request wrapper (#485)

* remove submit block request wrapper types

* fix tests

* fix lint

* Upgrade go-boost-utils (#488)

* Upgrade go-boost-utils

* pr comments

* remove commented out code

* Add custom json marshalling for versioned structs (#493)

* Add deneb signature checking for block contents

* Add deneb support for type conversions

* Add redis and database tests to store deneb payloads

* Block submission to v3 validation endpoint

* Update signed block conversions

* Replace some expectCont with expectOk (#509)

* Allow fork epochs to be 0

* Make attestantio import names consistent (#510)

* Make attestantio import names consistent

* Fix linter errors & two comments

* Fix mistake in redis prefix name (#517)

* Fix mistake in redis prefix for deneb

* Fix typo in prefix

* rebase conflicts from main

* update submit block request

* bug fixes

* fix blob sidecar signature

* ssz encode request to publish block

* use v2 publish endpoint by default

* go mod tidy

* update relay to latest builder-specs

* update go mod

* fix lint and tests

* switch to json encoding instead of ssz for block publishing v2

* add blob logging

* address pr comments

* Handle no deneb fork schedule from beacon client (#572)

* backwards compatibility if no deneb schedule

* Update services/api/service.go

Co-authored-by: Chris Hager <[email protected]>

---------

Co-authored-by: Chris Hager <[email protected]>

* change specific error log to info because it's expected nowadays (#574)

* Add json and ssz marshalling tests (#573)

* add test vectors

* linting

---------

Co-authored-by: Justin Traglia <[email protected]>
Co-authored-by: Chris Hager <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants