Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send auction transcript to relay monitor #297

Merged
merged 7 commits into from
Nov 3, 2022
Merged

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Sep 7, 2022

📝 Summary

Sends the signed builder bid and signed blinded beacon block to the relay monitor to verify the integrity of the auction. See https://hackmd.io/@ralexstokes/SynPJN_pq for the types of faults detected.

⛱ Motivation and Context

📚 References


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@avalonche avalonche force-pushed the send-auction-transcript branch from 2ab6f0e to 98b9196 Compare September 12, 2022 15:37
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2022

Codecov Report

Merging #297 (0bf9acc) into main (46c074f) will decrease coverage by 0.14%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   66.66%   66.51%   -0.15%     
==========================================
  Files           7        7              
  Lines         888      902      +14     
==========================================
+ Hits          592      600       +8     
- Misses        262      267       +5     
- Partials       34       35       +1     
Flag Coverage Δ
unittests 66.51% <28.57%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/service.go 78.57% <28.57%> (-0.72%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@avalonche avalonche force-pushed the send-auction-transcript branch from 98b9196 to ee41497 Compare September 19, 2022 16:39
@metachris metachris added the next up It's next up label Sep 22, 2022
server/backend.go Outdated Show resolved Hide resolved
server/backend.go Outdated Show resolved Hide resolved
@metachris metachris added in development 🛠️ not yet ready to be merged and removed next up It's next up labels Oct 21, 2022
server/service.go Outdated Show resolved Hide resolved
server/service_test.go Outdated Show resolved Hide resolved
@avalonche avalonche force-pushed the send-auction-transcript branch from ee41497 to 0bf9acc Compare October 31, 2022 17:11
Copy link
Collaborator

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments, overall looks great!

server/service.go Outdated Show resolved Hide resolved
server/service.go Outdated Show resolved Hide resolved
server/service.go Outdated Show resolved Hide resolved
server/service.go Outdated Show resolved Hide resolved
@avalonche avalonche force-pushed the send-auction-transcript branch from 8615213 to f74b4eb Compare November 3, 2022 18:40
@avalonche avalonche force-pushed the send-auction-transcript branch from f74b4eb to 36eb390 Compare November 3, 2022 18:41
@metachris metachris added the next up It's next up label Nov 3, 2022
Copy link
Collaborator

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice updates!

@avalonche avalonche merged commit 7713bd9 into main Nov 3, 2022
@avalonche avalonche deleted the send-auction-transcript branch November 3, 2022 20:02
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
* Send auction transcript to relay monitor

* increase test timeout

* remove loop

* fix merge conflicts

* pr feedback

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss in development 🛠️ not yet ready to be merged next up It's next up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants