Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few a few minor things #361

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Few a few minor things #361

merged 1 commit into from
Sep 27, 2022

Conversation

jtraglia
Copy link
Collaborator

📝 Summary

  • Remove some unused variables.
  • Rename variable to fix possible variable/package name collision.
  • Remove some unnecessary type casts.

⛱ Motivation and Context

I like to fix the small things too.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

Codecov Report

Merging #361 (4704470) into main (dd1f822) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files           5        5           
  Lines         679      679           
=======================================
  Hits          556      556           
  Misses         94       94           
  Partials       29       29           
Flag Coverage Δ
unittests 81.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/service.go 80.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metachris
Copy link
Collaborator

Thanks! 🧹

@metachris metachris merged commit 025acf0 into flashbots:main Sep 27, 2022
@jtraglia jtraglia deleted the fix-a-few-things branch September 27, 2022 15:02
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants