Reth v1.1.1 #255
Merged
Reth v1.1.1 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live_builder/building/mod done
root_hash_task_pool removed.
liamaharon
approved these changes
Nov 28, 2024
Comment on lines
+109
to
+110
| // @Pending: Eval replacing Bytes for ArrayVec to avoid the copy or dig deeper into low-level. | ||
| children[index as usize] = Some(Bytes::copy_from_slice(rlp_data.as_ref())); |
There was a problem hiding this comment.
This is for @dvush
crates/rbuilder/src/building/builders/parallel_builder/simulation_cache.rs
Outdated
Show resolved
Hide resolved
Comment on lines
-152
to
+160
| .map(|tx| tx.envelope_encoded().to_vec().into()) | ||
| .map(|tx| { | ||
| let mut buf = Vec::new(); | ||
| tx.encode_2718(&mut buf); | ||
| buf.into() | ||
| }) |
There was a problem hiding this comment.
Do we have a way to ensure the new encoding is correct?
There was a problem hiding this comment.
Not that I remember. We trust on reth tests.
| tx.tx.tx.value() | ||
| tx.tx.value() |
crates/transaction-pool-bundle-ext/bundle_pool_ops/rbuilder/Cargo.toml
Outdated
Show resolved
Hide resolved
ferranbt
approved these changes
Nov 28, 2024
…ion_cache.rs Co-authored-by: liamaharon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test