You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'm a little bit confused, can you clarify what need to be specified as requires in _get_requires_for_build function and what need to be set as install_requires? Thanks!
Sorry I'm a little bit confused, can you clarify what need to be specified as requires in _get_requires_for_build function and what need to be set as install_requires? Thanks!
install_requires in setup.py and project.dependencies in pyproject.toml specifies packages required at runtime. build-system.requires in pyproject.toml specifies packages required to build the package, and _get_requires_for_build can specifies addtional packages considering options like FLASHINFER_ENABLE_AOT=1.
In JIT mode, we do not build shared objects when building the package, but users need ninja to accelerate building. Thus ninja should be in install_requires/project.dependencies. It is ok that _get_requires_for_build specifies ninja but not necessary.
In AOT mode it is just opposite. ninja is supposed to be present in _get_requires_for_build and absent in install_requires/project.dependencies.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ur4t
changed the title
No description provided.