initrd-setup-root-after-ignition: Ensure /etc/flatcar/sysext exists #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Mar 12, 2024
pothos
approved these changes
Mar 12, 2024
Nothing guarantees that this folder is created, so we need to mkdir it before moving the sysext into it. Otherwise the user is forced to create it with ignition when specifying sysexts to install in /etc/flatcar/enabled-sysext.conf. Signed-off-by: Jeremi Piotrowski <[email protected]>
ZFS provides dracut scripts that get automatically picked up by dracut/update-bootengine. Explicitly omit the zfs module when calling dracut. Signed-off-by: Jeremi Piotrowski <[email protected]>
The value of ROOT may be interpreted by some scripts in the chroot but is not correct after chrooting. Unset it before executing chroot. Signed-off-by: Jeremi Piotrowski <[email protected]>
|
I've pushed two more changes, can you take another look @pothos ? |
3 tasks
pothos
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing guarantees that this folder is created, so we need to mkdir it before moving the sysext into it. Otherwise the user is forced to create it with ignition when specifying sysexts to install in
/etc/flatcar/enabled-sysext.conf.