-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip coreos-cloudinit if ignition is used #27
Skip coreos-cloudinit if ignition is used #27
Conversation
This change skips coreos-cloudinit when config drive is used, if the system was configured using ignition. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
1228569
to
8a67234
Compare
Co-authored-by: Kai Lüke <[email protected]>
Can we merge this or does it need more testing? Afterwards we also need a scripts PR that bumps the commit ref. |
With the exclusion of OpenStack for this service, it is now skipped regardless of whether or not the system was configured via ignition or not: flatcar ~ # systemctl status user-configdrive
○ user-configdrive.service - Load cloud-config from /media/configdrive
Loaded: loaded (/usr/lib/systemd/system/user-configdrive.service; static)
Active: inactive (dead) On other platforms it should just skip configuring it because of the |
I've tested the condition in the possible cases it can hit and it looks good. You can click merge and open the scripts PR or if you are busy, also ok and I can do it :) |
Sorry for the slowness on this. I was at Kubecon last week and just got back. I will create the scripts PR in the morning. |
This change skips coreos-cloudinit when config drive is used, if the system was configured using ignition.
Building an image with this change now. Will report back once I manage to test it.
Addresses behavior seen in: