-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cork
: add --json-key
to create
and download
#239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it allows user to pull SDK from a private GCS bucket location. Signed-off-by: Mathieu Tortuyaux <[email protected]>
this --json-key is empty by default. If a user passes a key, it will be used to create a GCS client. Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/update-sdk-url
branch
from
October 4, 2021 16:14
599171e
to
b98af28
Compare
pothos
approved these changes
Oct 4, 2021
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 5, 2021
it pulls flatcar/mantle#239 to be able to use `--json-key` in order to access private GCS bucket Signed-off-by: Mathieu Tortuyaux <[email protected]>
This was referenced Oct 5, 2021
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 6, 2021
it pulls flatcar/mantle#239 to be able to use `--json-key` in order to access private GCS bucket Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 7, 2021
it pulls flatcar/mantle#239 to be able to use `--json-key` in order to access private GCS bucket Signed-off-by: Mathieu Tortuyaux <[email protected]>
dongsupark
pushed a commit
to flatcar/scripts
that referenced
this pull request
Oct 13, 2021
it pulls flatcar/mantle#239 to be able to use `--json-key` in order to access private GCS bucket Signed-off-by: Mathieu Tortuyaux <[email protected]>
dongsupark
pushed a commit
to flatcar/scripts
that referenced
this pull request
Oct 13, 2021
it pulls flatcar/mantle#239 to be able to use `--json-key` in order to access private GCS bucket Signed-off-by: Mathieu Tortuyaux <[email protected]>
dongsupark
pushed a commit
to flatcar/scripts
that referenced
this pull request
Oct 13, 2021
it pulls flatcar/mantle#239 to be able to use `--json-key` in order to access private GCS bucket Signed-off-by: Mathieu Tortuyaux <[email protected]>
dongsupark
pushed a commit
to flatcar/scripts
that referenced
this pull request
Oct 13, 2021
it pulls flatcar/mantle#239 to be able to use `--json-key` in order to access private GCS bucket Signed-off-by: Mathieu Tortuyaux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add the
--json-key
flag tocreate
anddownload
subcommands fromcork
. It allows a user to pass a GCS credential file path tocork
in order to download from a private GCS bucket.update
command use the flags from the creation flags set, so no need to update this part:Testing done