azure: Add support for using an external availability set and resource group #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not meant to be merged - i just needed the CI to build a container image |
jepio
force-pushed
the
tormath1/azure+jepio
branch
from
db7c076 to
ebb35c5
Compare
|
@jepio do we still need this? |
|
Actually i think we do - I use this regularly. Do you mind if I rebase, drop the reverts and resubmit? |
Sure, feel free. |
jepio
force-pushed
the
tormath1/azure+jepio
branch
from
ebb35c5 to
3ac46a6
Compare
jepio
changed the title
|
@tormath1 would you review? |
can be used to deploy resources in an existing resource group Signed-off-by: Mathieu Tortuyaux <[email protected]>
can be used to deploy instances in. Signed-off-by: Mathieu Tortuyaux <[email protected]>
Signed-off-by: Mathieu Tortuyaux <[email protected]> Signed-off-by: Jeremi Piotrowski <[email protected]>
The remaining objects stay in a garbage collected kola managed group. This allows us to use an availability set for the vms, which requires that VMs be in the same rg as the avset. Kola correctly removes the VMs through TerminateInstance() separately from any RG that it creates. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
force-pushed
the
tormath1/azure+jepio
branch
from
3ac46a6 to
7f3319e
Compare
tormath1
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach to reusing a resource group: only store VM object in the passed resource group and all other objects go in the kola managed RG. Instances already get deleted separately from rgs at the end of the run.
This is needed to support availability set that may be pinned to a specific compute resource. VMs that are part of an availability set must share a resource group with the availability set and must share a vnet.