-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootengine: fix kmod-static-nodes #1654
Conversation
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8702461657 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A changelog entry in changelog/bugfixes/2024-02-13-TOPIC.md
would be good with something like - Resolved problem causing fallout ([bootengine#85](https://github.com/flatcar/bootengine/pull/85))
620fa33
to
57b4fbe
Compare
Note that this issue is present also on Flatcar versions up to 3510 and maybe older versions (I could track it down up to 3510 using a Hyper-V vm. 3374 did not properly boot because of ignition/cloud-init implementation). |
Update the bootengine commit id to use the fix from: flatcar/bootengine#85 Fixes kubevirt vm creation by ensuring that /dev/vhost-net static node gets created Fixes: flatcar/Flatcar#1336 Signed-off-by: Adrian Vladu <[email protected]>
57b4fbe
to
70ad180
Compare
We can do a backport by picking the bootengine commit into backport branches like |
I suggest to have this change tested better (a few test iterations of the HEAD) before backporting it to the beta / stable branches. For the moment, I am the only person affected by the kubevirt issue. Thanks. |
bootengine: fix kmod-static-nodes
Note that this PR has not been backported yet and only Flatcar version >= 3913 has the fix. |
Update the bootengine commit id to use the fix from: flatcar/bootengine#85
Fixes: flatcar/Flatcar#1336
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.