Stop forwarding unnecesary FDs in fusermount-wrapper.sh #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following analysis from [1] we can conclude that explicit forwarding of fd1 and fd2 is redundant as they're always forwarded and unconditional forwarding of fd3 is at least unnecessary and may be even harmful therefore they should all be dropped especially when original author doesn't recall the need for them here [2]. Fixes #42 [1] flatpak/flatpak-xdg-utils#55 (comment) [2] #42 (comment)
|
Started test build 58850 |
|
Build 58850 successful |
This was referenced Oct 2, 2022
Closed
real-yfprojects
added a commit
to real-yfprojects/flatpak-com.borgbase.Vorta
that referenced
this pull request
Oct 3, 2022
Forwarding fd 3 sometimes leads to an error because the fd isn't available. At the same time forwarding fd 3 doesn't seem to be needed as explained in flathub/org.flatpak.Builder#47. As noted there fd 0, 1 and 2 will always be forwarded so specifying those explicitly isn't needed. * dependencies/fusermount-wrapper.sh : Remove args for forwarding fd 1, 2 and 3.
Hofer-Julian
pushed a commit
to flathub/com.borgbase.Vorta
that referenced
this pull request
Oct 3, 2022
Forwarding fd 3 sometimes leads to an error because the fd isn't available. At the same time forwarding fd 3 doesn't seem to be needed as explained in flathub/org.flatpak.Builder#47. As noted there fd 0, 1 and 2 will always be forwarded so specifying those explicitly isn't needed. * dependencies/fusermount-wrapper.sh : Remove args for forwarding fd 1, 2 and 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following analysis from [1] we can conclude that explicit forwarding of fd1 and fd2 is redundant as they're always forwarded and unconditional forwarding of fd3 is at least unnecessary and may be even harmful therefore they should all be dropped especially when original author doesn't recall the need for them here [2].
Fixes #42
[1] flatpak/flatpak-xdg-utils#55 (comment)
[2] #42 (comment)