Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An option to remember the selection in the application portal #302

Closed
furkanusta opened this issue Feb 17, 2019 · 7 comments
Closed

An option to remember the selection in the application portal #302

furkanusta opened this issue Feb 17, 2019 · 7 comments

Comments

@furkanusta
Copy link

I am using Zotero flatpak application and every time I try to open a pdf file it brings up the Application selection portal and I have to choose evince from there. It would be useful if they can use the default application in the system or have a checkbox in the portal to remember the selection.

This issue seems to be already reported in the Zotero flathub page: flathub/org.zotero.Zotero#15

And kind of related to #126
@A6GibKm
Copy link
Contributor

A6GibKm commented Apr 11, 2019

This also applies to open attachments in org.gnome.Geary and org.gnu.emacs.

@rvlobato
Copy link

Also, for org.telegram.desktop

@ghost
Copy link

ghost commented Aug 13, 2019

Same problem on nwjs applications. It gets really annoying and often the Open With window appears twice.

@go-ten
Copy link

go-ten commented Oct 24, 2019

also for Thunderbird and Shotwell.

Any news ?

Regards

@matthiasclasen
Copy link
Contributor

The portal remembers the choice. It also has a threshold mechanism to stop asking if you chose the same app for a certain number of times. But it is currently not being used - nobody set the the threshold to something smaller than MAXINT

@Fak3
Copy link

Fak3 commented Nov 11, 2019

But it is currently not being used - nobody set the the threshold to something smaller than MAXINT

Oh, where can i configure this? Is that runtime option or build-time?

@matthiasclasen
Copy link
Contributor

I've now changed things so that the portal will stop asking if you choose the same app 3 times

@mihaic mihaic mentioned this issue Mar 26, 2020
Closed
agx pushed a commit to agx/xdg-desktop-portal that referenced this issue Dec 20, 2023
@mcatanzaro
appchooserdialog: avoid crash when there are few app options
7d2b3e2 
Problem is the code reads off the end of the choices list when the
number of choices is less than INITIAL_LIST_SIZE - 1.

Fixes flatpak#302
agx pushed a commit to agx/xdg-desktop-portal that referenced this issue Dec 20, 2023
@mcatanzaro
appchooserdialog: improve safety of ensure_default function
1f30f6c 
We can calculate the bounds ourselves, instead of passing them in. This
way we don't need to rely on the caller to avoid buffer overflow. This
would have prevented flatpak#302.
agx pushed a commit to agx/xdg-desktop-portal that referenced this issue Dec 20, 2023
@hadess
Merge pull request flatpak#303 from mcatanzaro/mcatanzaro/flatpak#302
8600ca1 
    appchooserdialog: avoid crash when there are few app options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Fak3 @matthiasclasen @rvlobato @furkanusta @A6GibKm @go-ten