-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Persistence notification flags #786
Conversation
FDO Notifications could be set as transient and so only be shown without being persistent if the desktop environment supported that. It's still possible to support such parameter, as applications may want to bother less the users.
3ce5078
to
baa8b03
Compare
These were supported by FDO Notifications protocol, but we don't support them in the portal. However, given that those can bother the user, adding a further permission check, so that users can ignore such notifications flag.
baa8b03
to
d907d38
Compare
I wanted to add permission tests, but sadly this is a bit complex at the moment because of the So, I thought about defining a So, any suggestion here? |
@GeorgesStavracas hey, could you have a look at this? And #791 maybe :-) |
So, the paradigm to make things more testable is in #904, so once that lands this will be easily testable. |
@3v1n0 is this still relevant with the Notifications v2 portal landing soon? |
I think this can be closed since notification v2 has a new property |
FDO Notifications had persistence flags, we don't support them in the portal, but applications may want to be able to still use them.
While transient notifications can be shown as they are, resident ones could instead be bothering an user, so add a further permission check in such case.