Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ruby 2.4 frozen string literals #118

Closed
flavorjones opened this issue Feb 13, 2017 · 4 comments
Closed

support ruby 2.4 frozen string literals #118

flavorjones opened this issue Feb 13, 2017 · 4 comments
Milestone
v2.4.0

Comments

@flavorjones
Copy link
Owner

as of 7a10151, there are 605 errors when running tests with RUBYOPT="--enable-frozen-string-literal --debug=frozen-string-literal"

Acceptance criteria:

  • ruby 2.4 test task runs with frozen-string-literal ruby options set and passes
@flavorjones flavorjones reopened this Nov 13, 2017
@flavorjones
Copy link
Owner Author

Loofah tests now pass; remaining failures need support from Crass. Will open a PR to that project.

@flavorjones flavorjones mentioned this issue Nov 13, 2017
Merged
@flavorjones
Copy link
Owner Author

See rgrove/crass#3 to monitor progress. Closing this ticket.

@flavorjones
Copy link
Owner Author

Actually, reopening so that once Crass supports this option, I can bake it into Loofah's tests.

@flavorjones flavorjones reopened this Nov 13, 2017
@flavorjones
Copy link
Owner Author

OK - revisiting this, all tests pass locally when run with RUBYOPT="--enable-frozen-string-literal --debug=frozen-string-literal" so now I want to add this to the CI pipelines.

flavorjones added a commit that referenced this issue Nov 25, 2019
@flavorjones
test suite should check compatibility with frozen string literals
82ae384 
related to #118
flavorjones added a commit that referenced this issue Nov 25, 2019
@flavorjones
add rubocop as dev dep and configure security and frozen string cops
5ce3a71 
related to #118
flavorjones added a commit that referenced this issue Nov 25, 2019
@flavorjones
add magic comment for frozen string literals to all files
0783f5b 
related to #118
@flavorjones flavorjones added this to the v2.4.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
1 participant
@flavorjones