Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow select URI Data Mediatypes #120

Closed
wants to merge 1 commit into from

Conversation

mrpasquini
Copy link
Contributor

@mrpasquini mrpasquini commented Feb 27, 2017

How is this for a start at resolving issue #101 ?

  • Allows data as a protocol but then applies a filter on allowed mediatypes
  • Is not checking/validating the optional ;base64 part of data:<mediatype>[;base64],<data>
  • Is not checking/validating the data/data encoding

@mrpasquini
Copy link
Contributor Author

Hey @flavorjones, Can you take a look and comment?

@nguyenmighty
Copy link

Will this commit be in 2.1.0 version?

@mrpasquini
Copy link
Contributor Author

Ping @flavorjones
Happy to make this more generically support partial protocols if that is preferred.

@PratheepV
Copy link

+1

@drosboro
Copy link

drosboro commented Aug 5, 2017

+1 This would be very helpful, as a starting point.

@flavorjones
Copy link
Owner

Sorry for the long silence; this PR looks mostly good. I'd like to add a negative test and then I'll merge it. Working on it now.

flavorjones added a commit that referenced this pull request Sep 24, 2017
and update CHANGELOG with this feature and a thank-you.

Related to #101, #120.
@flavorjones
Copy link
Owner

Merged manually! Will be in the next release. Thanks so much for your contribution and patience!

@mrpasquini
Copy link
Contributor Author

Awesome, Thanks!

@flavorjones
Copy link
Owner

Is in 2.1.0 that just shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants