-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added read_schema
#196
Added read_schema
#196
Conversation
Has the official Rust implementation moved to this repo / space after the donation to Apache? https://github.com/apache/avro/tree/master/lang/rust If so, think it makes sense to update some pointers in this repository. |
Some pointers: |
For some extra context the idea we were looking for was to have a consolidated upstream Apache Avro Rust implementation, so we contacted @flavray and the Yelp authors to have the code donated and fortunately this happened succesfully. Migration to Apache Avro of the codebase already happened. However we have not done yet the first release so these changes can probably still get in. Some things did not happen as planned (due to multiple reasons and personal changes), we are lacking maintainers so any help will be welcomed. We expect to have a new Avro release that will include the rust Avro version 'soon' so if you do the changes there we can get them in. Slightly unrelated but good for awareness: We expect the first release to be fully consistent with the CC @RyanSkraba since we are syncing about the next release |
Thanks @iemejia for the full context and status of the Rust implementation! Also let me know when I should give access to @Igosuki you recently contributed the Avro table provider in DataFusion - maybe you're interested as well to help out on the Apache Avro side :D? |
I didn't know this is being migrated to apache ! I have a fork where I added protocol support for schemas generated from idl here Igosuki@9f51ffa let me know if there's anything I can help with |
I can help with the maintenance. After jorgecarleitao/arrow2#406 I am familiar with the format and how each type is encoded (and the code in avro-rs is very easy to follow, I must say =)
|
I somehow missed the rest of the conversation. @Igosuki @jorgecarleitao would you be interested in taking the maintenance on the Apache side? It will be fantastic to have more hands helping, sadly things have not gone as expected since the move to Apache.
For the release cadence this is up to the maintainers needs, at this point we plan to do the first release with 1.11.0 but then we could maybe go in with rust specific releases if required, the issue is the usual of the Apache 72h vote. Also there are two things Avro does NOT follow semver and for the particular case of the Rust implementation we do not want to offer strong stability guarantees to help new contributors evolve the implementation. I had a short discussion with @flavray last week and he seems to be interested on taking back some review tasks on the Apache branch so with a little bit of help we could get things again rolling. If you are in for helping please write here or ping me at the ASF slack and we can discuss more. |
I am interested on helping maintain the apache side. I don't know what you planned for future releases but I already have quite a few things in mind aiming to attain feature parity with Java. |
This PR moves the functionality to read the header of a block to outside of the
Block
struct, so that users can read the schema without having to initialize aReader
.Users will need to re-seek the file if they want to then pass it to
Reader
, but the primary goal here is to offer users the ability to read the schema, e.g. to build logical plans based on the file.Built on top of #194