Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Chrome on macOS isn't showing icon #20865

Closed
noahtalerman opened this issue Jul 30, 2024 · 6 comments
Closed

Google Chrome on macOS isn't showing icon #20865

noahtalerman opened this issue Jul 30, 2024 · 6 comments
Assignees
@ghernandez345
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.58.0

Comments

@noahtalerman
Copy link
Member

noahtalerman commented Jul 30, 2024 •
edited by marko-lisica
Loading

Fleet version: Observed in Fleet's dogfood environment

💥  Actual behavior

Software title page for Windows:

Screenshot 2024-07-30 at 5 49 55 PM

Software title page for macOS:
Screenshot 2024-07-30 at 5 49 26 PM

🛠️ To fix

As specified here in Figma, each title and version starting with "Google Chrome" should have icon.
@noahtalerman noahtalerman added bug Something isn't working as documented ~released bug This bug was found in a stable release. :product Product Design department (shows up on 🦢 Drafting board) #g-endpoint-ops Endpoint ops product group :incoming New issue in triage process. labels Jul 30, 2024
@noahtalerman noahtalerman self-assigned this Jul 30, 2024
@noahtalerman
Copy link
Member Author

Hey @marko-lisica we expect any software title with "Google Chrome" in it's name to get the Chrome icon right?

@marko-lisica
Copy link
Member

Hey @marko-lisica we expect any software title with "Google Chrome" in it's name to get the Chrome icon right?

@noahtalerman That's correct, I'll update "To fix" section and move this back to the engineering board.

@marko-lisica marko-lisica added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :product Product Design department (shows up on 🦢 Drafting board) labels Aug 12, 2024
@sharon-fdm sharon-fdm removed their assignment Aug 14, 2024
@getvictor getvictor added the ~frontend Frontend-related issue. label Aug 14, 2024
@sharon-fdm
Copy link
Collaborator

From Rachel: Estimation could be low depending on found issues.

@sharon-fdm sharon-fdm removed the :incoming New issue in triage process. label Aug 15, 2024
@sharon-fdm sharon-fdm added this to the 4.58.0-tentative milestone Sep 16, 2024
@iansltx iansltx removed their assignment Sep 17, 2024
@RachelElysia RachelElysia added #g-mdm MDM product group and removed #g-endpoint-ops Endpoint ops product group labels Sep 18, 2024
@RachelElysia
Copy link
Member

Paired with @ghernandez345 today and he found this fix quickly. He's going to do a PR for it so switched this ticket to the MDM board. CC: @sharon-fdm @georgekarrv

@ghernandez345 ghernandez345 mentioned this issue Sep 19, 2024
Merged
2 tasks
ghernandez345 added a commit that referenced this issue Sep 19, 2024
@ghernandez345
show correct chrome software icon for chrome packages (#22233)
9a1b376 
relates to #20865

Show the correct software icon for uploaded chrome packages


![image](https://github.com/user-attachments/assets/85215a31-0b63-438b-a4dc-661cea026c3b)

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
- [x] Manual QA for all new/changed functionality
@PezHub
Copy link
Contributor

PezHub commented Sep 23, 2024

QA Notes:

I see the correct icon now for the mac pkg (enterprise) installer
Screenshot 2024-09-23 at 10 05 59 AM

@fleet-release
Copy link
Contributor

Chrome icon unseen,
In Mac's fleet, a blank screen.
Fix brings clarity.

@georgekarrv georgekarrv removed the :demo label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghernandez345 ghernandez345

Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Projects
None yet
Milestone
4.58.0
Development

No branches or pull requests