Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fleet UI: Dropdown styling nits (centering/padding) #21129

Closed
RachelElysia opened this issue Aug 7, 2024 · 2 comments
Closed

Fleet UI: Dropdown styling nits (centering/padding) #21129

RachelElysia opened this issue Aug 7, 2024 · 2 comments
Assignees
@RachelElysia
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.58.0

Comments

@RachelElysia
Copy link
Member

Fleet version:
main
Web browser and operating system:

💥  Actual behavior

The main dropdown for Hosts, Software, and Queries table have the following issues:

  • The dropdown text is not vertically centered, looks like the container is 2px shy of the entire height
  • The dropdown options feel like they're cut off at the bottom
Screenshot 2024-08-07 at 9 49 36 AM Screenshot 2024-08-07 at 9 49 11 AM Screenshot 2024-08-07 at 9 48 55 AM Screenshot 2024-08-07 at 9 48 44 AM Screenshot 2024-08-07 at 9 48 12 AM Screenshot 2024-08-07 at 9 47 58 AM

🧑‍💻  Steps to reproduce

  1. Look at table dropdowns

Video of nits

https://www.loom.com/share/6fdcd1ccf84a419e9bdbe1c4be68839b?sid=adc6b92f-4015-4011-8c18-ddb04fdba1e9

🕯️ More info (optional)

N/A

FE
@RachelElysia RachelElysia added bug Something isn't working as documented ~frontend Frontend-related issue. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-endpoint-ops Endpoint ops product group :incoming New issue in triage process. labels Aug 7, 2024
@sharon-fdm sharon-fdm removed the :incoming New issue in triage process. label Aug 8, 2024
@lukeheath lukeheath added the ~released bug This bug was found in a stable release. label Aug 9, 2024
@RachelElysia RachelElysia self-assigned this Sep 23, 2024
@RachelElysia RachelElysia mentioned this issue Sep 23, 2024
Merged
1 task
@RachelElysia
Copy link
Member Author

Another instance of cutting off needs fixing:
Screenshot 2024-09-23 at 1 09 57 PM

@RachelElysia RachelElysia added this to the 4.58.0-tentative milestone Sep 24, 2024
@RachelElysia RachelElysia mentioned this issue Sep 25, 2024
Closed
@fleet-release
Copy link
Contributor

Dropdowns align just so,
Users flow like water, smooth.
Fleet's ease in each click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RachelElysia RachelElysia

Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.58.0
Development

No branches or pull requests
4 participants
@lukeheath @RachelElysia @fleet-release @sharon-fdm