Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Host status dropdown styling fixes #22314

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Sep 23, 2024

Issue

Cerra #21129

Description

  • Remove max-height causing the dropdown options to be cut off
  • Looks like the centering bug was already fixed (likely global fix happened with work on software dropdown options)

Note: Also removed some related sandbox code (context: sandbox is a deprecated feature we had for users to trial premium and it's been a long run of trying to remove all related code)

Screenshot of 1 of the fixes

Screenshot 2024-09-23 at 12 51 48 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.22%. Comparing base (b14f7fa) to head (92179b2).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22314   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files        1496     1496           
  Lines      117247   117247           
  Branches     3563     3514   -49     
=======================================
  Hits        76474    76474           
- Misses      33636    33637    +1     
+ Partials     7137     7136    -1     
Flag Coverage Δ
frontend 52.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iansltx
iansltx previously approved these changes Sep 23, 2024
@RachelElysia RachelElysia merged commit 3b001ea into main Sep 24, 2024
14 checks passed
@RachelElysia RachelElysia deleted the 21129-host-dropdown-bugs branch September 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants