-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to automatically migrate Windows workstations #22075
Comments
Hey @zayhanlon heads up, this user story didn't make it into the upcoming engineering sprint because we didn't get it estimated in time. It's still prioritized. We left it on the drafting board so that it can be pulled into the next engineering sprint. |
Hey @georgekarrv just giving you a reminder that this story is ready to spec. Please let us know if we can help get this ready for estimation :) |
Hey @georgekarrv just giving you a ping! as a reminder that this story is ready to spec. Please let us know if we can help get this ready for estimation. |
@noahtalerman @georgekarrv @rachaelshaw just a heads-up that there are fleetd changes required for this story (to receive a notification to unenroll from the previous MDM provider), so that feature will require the latest Mentioning because the story currently states |
@mna thanks for calling that out! I updated the issue description to capture that. @noahtalerman do you reckon that's worth calling out in the settings page copy or the docs? Or is it expected that users keep fleetd up-to-date? |
Thanks @rachaelshaw!
Good thinking but I think no copy or doc changes needed. It's expected to keep Fleet up-to-date. Most users rely on our update servers so when we push this fleetd update all their computers will get it. For users who manage fleetd version themselves (pin it to a lower version), they can check the releases page for which fleetd version corresponds to the latest Fleet features. |
@noahtalerman answering the questions you listed in the "QA -> Testing Notes" section of the story (not sure if that was for me/ the implementer of the solution or to be answered by QA, but in any case here are my answers now that the solution is implemented):
Migration requires the host to be online with fleetd communicating with Fleet. Offline hosts would receive the notification to start the migration when they come online.
The migration is a two-step process: first unenroll from the old MDM, wait for confirmation on the server, then enroll in Fleet. So the host is either "still enrolled in the old MDM", "unenrolled from any MDM", or "enrolled in Fleet". From my tests, the switch is quite fast (a minute or two).
You mean Fleet instances that have Windows MDM turned on before upgrading to the version that supports migration? They will still have it on, but migration will be disabled after upgrade and will need to be explicitly enabled (either via UI or fleetctl).
Hosts that are already in Fleet MDM stay as-is, they won't execute any action for a migration.
The MDM stats section of the dashboard show the details of hosts vs MDM solution, but those stats are generated in a cron job that runs every hour. The specific hosts' details page will show what MDM they are part of (or not in MDM) during the switch based on what the host reported. |
My QA of the feature branch now that all sub-tasks are implemented: Windows MDM turned off, 2 Windows hosts enrolled, one already in a 3rd-party MDM before enrolling into Fleet, the other will be shortly, before MDM is turned on: Then I enrolled the DreamQuest machine to the 3rd-party MDM, now that it is orbit-enrolled in Fleet. So now both Windows hosts are enrolled in a 3rd-party: Now I turn on Windows MDM, but not the migration yet: The "MDM turned on" activity gets created: Both hosts remain in the 3rd-party MDM: I turn on Windows migration via
The activity gets created and a host is already migrated: And very soon after, both hosts are now enrolled into Fleet MDM: Sent a trigger to speed up calculation of aggregated stats: (it says 3 because I have an ABM pending macOS host too) Tooltip was properly updated on the "On (manually)" status: Turning Windows migration off via Turning Windows MDM off altogether generates only that activity, not the Windows migration disabled one: Note that Windows hosts do not properly unenroll from Fleet MDM, there's a distinct issue for that as this is a released bug unrelated to that story: #24209 I believe the frontend does not know about the new activities at the moment, as they show up as the generic layout, instead of what was designed in Figma. I'll create an issue to track that (#24269). The rest looks good to me. |
Video recording of the flow (@nonpunctual as you mentioned you wanted to see this): https://drive.google.com/file/d/1WkViPyTrmdZVscjWsAwFVqRXcqbtiatM/view?usp=drive_link |
Additional QA tests and notes:
I also tested the following scenarios using a Surface Laptop enrolled in a 3rd Party MDM solution (from a different vendor): 1a. Enroll device in 3rd party mdm before adding to fleet ✅
1b. Enroll device in 3rd party mdm before adding to fleet ✅
Additional Note - I did not have time nor resources to test a migration from a Windows host enrolled in |
Hey @georgekarrv I think we missed guide updates for this user story. If that's right, can you please help me track a bug for guide updates? cc @lukeheath |
#24842 Added as a subtask to this story |
Hey @mna what happens when I set Do we show an easy to understand error message? |
- Add missing reference docs for the following user story: - #22075
@rachaelshaw I noticed that we were missing YAML reference docs and I'm not sure why. Did we merge the docs into the wrong reference docs branch and then, later, the changes got stomped on? I opened a PR to add the missing docs here: #24891 |
Hi @noahtalerman , we do get a user friendly error when setting
|
- Add missing reference docs for the following user story: - #22075
Guide updates are merged! #24984 Closing this story. |
Migrate with ease now, |
Goal
Objective
Customer promises + renewal requests
Original request
Context
Changes
Product
windows_migration_enabled
#24891Engineering
QA
Risk assessment
Manual testing steps
Alternative tests that would be good to cover if possible:
fleetctl gitops
to enable MDM migrationAlso, see testing notes below, and the results of my (@mna) QA of the feature branch here: #22075 (comment).
Testing notes
@mna :
@noahtalerman:
Edge cases to consider:
Confirmation
The text was updated successfully, but these errors were encountered: