Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI hosts page doesn't support softwareStatus filters (installed, pending, failed) for hosts on No team #22136

Closed
2 tasks done
jacobshandling opened this issue Sep 16, 2024 · 2 comments
Closed
2 tasks done

UI hosts page doesn't support softwareStatus filters (installed, pending, failed) for hosts on No team #22136

jacobshandling opened this issue Sep 16, 2024 · 2 comments
Assignees
@jacobshandling @RachelElysia
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.57.0

Comments

@jacobshandling
Copy link
Contributor

jacobshandling commented Sep 16, 2024 •
edited by RachelElysia
Loading

Fleet version: 4.46.2

💥  Actual behavior

https://www.loom.com/share/052469f143e043ceb4e11062dd61c77d

🧑‍💻  Steps to reproduce

  1. Have host on No team
  2. Have software available for install on 'No team' hosts
  3. Go to that software's details page
  4. Click on any of the 3 install status links to filter hosts by that status for that software
  5. See hosts page without those filters reflected

🕯️ More info (optional)

N/A

🧑‍💻  Steps to QA

  1. Have host on No team
  2. Have software available for install on 'No team' hosts
  3. Go to that software's details page
  4. Click on any of the 3 install status links to filter hosts by that status for that software
  5. See hosts page without those filters reflected
  6. Create a pending install on a host
  7. Repeat steps 3-5 and see the host reflected in pending install

Initial and date of QA:

  • JS 9/18 QA recording of steps 1-5
  • JA 9/18 QA recording of steps 6-7
@jacobshandling jacobshandling added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. bug Something isn't working as documented ~frontend Frontend-related issue. labels Sep 16, 2024
@RachelElysia RachelElysia mentioned this issue Sep 16, 2024
Merged
1 task
@jacobshandling jacobshandling self-assigned this Sep 16, 2024
jacobshandling added a commit that referenced this issue Sep 16, 2024
@jacobshandling
UI - Host filters bug (#22132)
c0ac242 
## #22088 

- Hosts page filters were using the same type that had been updated with
additional, more granular options, but the filters for that page still
only support the aggregate options "install", "pending" or "failed".
Updated hosts page to use new type `SoftwareAggregateStatus` to maintain
functionality.
- Note that this does _not_ fix this related but distinct _released_
bug: #22136

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
@jacobshandling jacobshandling added the ~released bug This bug was found in a stable release. label Sep 16, 2024
jacobshandling added a commit that referenced this issue Sep 16, 2024
@jacobshandling
UI - Host filters bug (#22132)
3fd8f5b 
## #22088 

- Hosts page filters were using the same type that had been updated with
additional, more granular options, but the filters for that page still
only support the aggregate options "install", "pending" or "failed".
Updated hosts page to use new type `SoftwareAggregateStatus` to maintain
functionality.
- Note that this does _not_ fix this related but distinct _released_
bug: #22136

- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
@jacobshandling jacobshandling mentioned this issue Sep 16, 2024
Merged
2 tasks
jacobshandling added a commit that referenced this issue Sep 17, 2024
@jacobshandling
UI - Support software status filter for 'No teams' on the hosts page (#…
b93d262 
…22143)

## #22136 


![ezgif-4-00c412809f](https://github.com/user-attachments/assets/5c22cc43-8182-4769-b0b3-4d34fa427488)

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
jacobshandling added a commit that referenced this issue Sep 17, 2024
@jacobshandling
UI - Support software status filter for 'No teams' on the hosts page (#…
7a943ef 
…22143)

## #22136 


![ezgif-4-00c412809f](https://github.com/user-attachments/assets/5c22cc43-8182-4769-b0b3-4d34fa427488)

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <[email protected]>
@jacobshandling jacobshandling mentioned this issue Sep 17, 2024
Merged
jacobshandling added a commit that referenced this issue Sep 17, 2024
@jacobshandling
To RC: UI - Support software status filter for 'No teams' on the host…
02f0a81 
…s page … (#22163)

#### This PR already merged to `main`, see
#22143. This is against the release
branch so it can be included in 4.57.0 (issue #22136 )

Co-authored-by: Jacob Shandling <[email protected]>
@sharon-fdm
Copy link
Collaborator

sharon-fdm commented Sep 18, 2024 •
edited by getvictor
Loading

QA - @RachelElysia

@getvictor getvictor assigned RachelElysia and unassigned getvictor Sep 18, 2024
@lukeheath lukeheath added this to the 4.57.0 milestone Sep 18, 2024
@fleet-release
Copy link
Contributor

In cloud city's light,
Filter now shows install state,
Clarity takes flight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobshandling jacobshandling

@RachelElysia RachelElysia

Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Projects
None yet
Milestone
4.57.0
Development

No branches or pull requests
6 participants
@lukeheath @getvictor @jacobshandling @RachelElysia @fleet-release @sharon-fdm