Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA Wolf] Unable to update "All teams" policies #22145

Closed
qawolf-fleet opened this issue Sep 16, 2024 · 3 comments
Closed

[QA Wolf] Unable to update "All teams" policies #22145

qawolf-fleet opened this issue Sep 16, 2024 · 3 comments
Assignees
@jacobshandling
Labels
bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Milestone
4.57.0

Comments

@qawolf-fleet
Copy link

Fleet version: Fleet 0.0.0-SNAPSHOT-4413a20 • Go go1.19.4 (or newer)

Operating system: Linux 64-bit

Web browser: Google Chrome Version 109.0.5414.119 64-bit

🧑‍💻  Expected behavior

💥  Actual behavior

🐞 on Premium

Steps to reproduce:

  1. Log in
  2. Create and save a policy
  3. Edit the policy
  4. Attempt to save changes
    Expected: Success alert and edits save successfully
    Actual: "Something went wrong updating your policy" error alert as well as 400 error in console

Video:
https://www.loom.com/share/89f758d1afab4dd7bf0895e12ea7cd52?sid=1499c576-4b3f-4a77-971c-877cf915bc20 (https://www.loom.com/share/89f758d1afab4dd7bf0895e12ea7cd52?sid=1499c576-4b3f-4a77-971c-877cf915bc20)

Bug report:
https://app.qawolf.com/fleet/bug-reports/0efdfd5a-d439-45ed-bb71-af681096fcf0

Affected workflows:
• Edit existing policy platform selections - https://app.qawolf.com/fleet/workflows/clah59m7r4733356tp6dvvwap2i

If you are aware of this bug you can set the priority to low which will prevent it from causing a run failure.

More info
@qawolf-fleet qawolf-fleet added :incoming New issue in triage process. :reproduce Involves documenting reproduction steps in the issue bug Something isn't working as documented labels Sep 16, 2024
@sharon-fdm sharon-fdm added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-endpoint-ops Endpoint ops product group labels Sep 17, 2024
@sharon-fdm
Copy link
Collaborator

Can't reproduce on 4.56 on Dogfood.

@lukeheath
Copy link
Member

@sharon-fdm This is an unreleased bug. We haven't pushed the RC to dogfood yet.

@lukeheath lukeheath added the ~unreleased bug This bug was found in an unreleased version of Fleet. label Sep 17, 2024
@jacobshandling jacobshandling self-assigned this Sep 18, 2024
@jacobshandling jacobshandling changed the title [QA Wolf] Unable to update policies [QA Wolf] Unable to update "All teams" policies Sep 18, 2024
@jacobshandling jacobshandling mentioned this issue Sep 18, 2024
Merged
2 tasks
jacobshandling added a commit that referenced this issue Sep 18, 2024
@jacobshandling
UI: handle possibly 'null' 'storedPolicy.team_id' on update policy ca…
4ee79ae 
…ll (#22215)

## #22145 


![ezgif-2-c62195a3ba](https://github.com/user-attachments/assets/4db3fcf8-f706-40e5-a1e5-c422ff7ac6c6)

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <[email protected]>
jacobshandling added a commit that referenced this issue Sep 18, 2024
@jacobshandling
UI: handle possibly 'null' 'storedPolicy.team_id' on update policy ca…
37535d0 
…ll (#22215)

## #22145 


![ezgif-2-c62195a3ba](https://github.com/user-attachments/assets/4db3fcf8-f706-40e5-a1e5-c422ff7ac6c6)

- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality

Co-authored-by: Jacob Shandling <[email protected]>
@jacobshandling jacobshandling mentioned this issue Sep 18, 2024
Merged
jacobshandling added a commit that referenced this issue Sep 18, 2024
@jacobshandling
to RC: UI: handle possibly 'null' 'storedPolicy.team_id' on update po…
a3232b2 
…licy ca… (#22216)

#### This PR already merged to `main`, see
#22215. This is against the release
branch so it can be included in 4.57.0 (issue #22145 )

Co-authored-by: Jacob Shandling <[email protected]>
@lukeheath lukeheath added this to the 4.57.0 milestone Sep 18, 2024
@sharon-fdm sharon-fdm removed :incoming New issue in triage process. :reproduce Involves documenting reproduction steps in the issue labels Sep 19, 2024
@fleet-release
Copy link
Contributor

Policy edits failed,
Fleet's update would bring calm,
Cloud city breathes easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobshandling jacobshandling

Labels
bug Something isn't working as documented #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Projects
None yet
Milestone
4.57.0
Development

No branches or pull requests
5 participants
@lukeheath @jacobshandling @fleet-release @sharon-fdm @qawolf-fleet