Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Unreleased bugs) Fleet UI: 20404 edit software feature #22168

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Sep 17, 2024

Issue

Feature #20404
Unreleased bug ticket #22165

Description

  • Refetch page on edit software changes
  • Make modal wider

Screenrecording

https://www.loom.com/share/dbcf4dd71a214a3d8b2505e70fd4015e?sid=8bc14e9d-657d-4f6f-9a98-bfd0f1c7ccd9

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.19%. Comparing base (2d05f24) to head (02c5b00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22168   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files        1495     1495           
  Lines      117084   117084           
  Branches     3506     3555   +49     
=======================================
  Hits        76336    76336           
+ Misses      33624    33623    -1     
- Partials     7124     7125    +1     
Flag Coverage Δ
frontend 52.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia merged commit 7e389d1 into main Sep 17, 2024
14 checks passed
@RachelElysia RachelElysia deleted the 20404-unreleased-fe-bugs branch September 17, 2024 17:09
@RachelElysia RachelElysia mentioned this pull request Sep 17, 2024
29 tasks
iansltx pushed a commit that referenced this pull request Sep 17, 2024
…22189)

> [!NOTE]
> This PR is already merged in `main`, see
#22168 This is against the release
branch so it can be included in 4.57.0

```
 1148  git checkout fleetdm/minor-fleet-v4.57.0
 1149  git log main
 1150  git cherry-pick 7e389d1
 1151  git checkout -b 20404-fe-fix-rc
 1152  git push -u fleetdm 20404-fe-fix-rc
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants