Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use previous package filename for activity if installer edit doesn't change the package #22177

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Sep 17, 2024

Also adds a line in the makefile help for generate-doc, as it took me way too long to find that command this time.

Checklist for submitter

  • Manual QA for all new/changed functionality

…change the package

Also adds a line in the makefile help for generate-doc, as it took me way too long to find that command this time.
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (b111011) to head (a80d358).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22177   +/-   ##
=======================================
  Coverage   65.19%   65.20%           
=======================================
  Files        1495     1495           
  Lines      117084   117085    +1     
  Branches     3555     3555           
=======================================
+ Hits        76336    76346   +10     
+ Misses      33624    33619    -5     
+ Partials     7124     7120    -4     
Flag Coverage Δ
backend 66.49% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iansltx iansltx merged commit 518a4a1 into main Sep 17, 2024
23 checks passed
@iansltx iansltx deleted the 20404-be-bugfix branch September 17, 2024 20:21
@RachelElysia RachelElysia mentioned this pull request Sep 17, 2024
29 tasks
RachelElysia pushed a commit that referenced this pull request Sep 17, 2024
…change the package (#22177)

Also adds a line in the makefile help for generate-doc, as it took me
way too long to find that command this time.

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants