Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick: Pass through uninstall error messages from backend #22211

Merged

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Sep 18, 2024

Cherry-pick of #22208

Command run:

git checkout minor-fleet-v4.57.0 && git checkout -b uninstall-errors-passthrough-cherry-pick && git cherry-pick f7fab00 && git push -u origin uninstall-errors-passthrough-cherry-pick

Copy link
Member

@RachelElysia RachelElysia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (pending flakey test passing)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.

Please upload report for BASE (minor-fleet-v4.57.0@0b5b129). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...end/pages/hosts/details/cards/Software/helpers.tsx 27.77% 13 Missing ⚠️
...ages/hosts/details/cards/Software/HostSoftware.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             minor-fleet-v4.57.0   #22211   +/-   ##
======================================================
  Coverage                       ?   65.34%           
======================================================
  Files                          ?     1494           
  Lines                          ?   116657           
  Branches                       ?     3501           
======================================================
  Hits                           ?    76228           
  Misses                         ?    33316           
  Partials                       ?     7113           
Flag Coverage Δ
frontend 52.05% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iansltx iansltx merged commit 39e5317 into minor-fleet-v4.57.0 Sep 18, 2024
11 checks passed
@iansltx iansltx deleted the uninstall-errors-passthrough-cherry-pick branch September 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants