Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article deploy software packages #22245

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

spokanemac
Copy link
Contributor

Article: Guide update deploy software packages #21841

fleet-release
fleet-release previously approved these changes Sep 19, 2024
@lukeheath lukeheath added this to the 4.57.0 milestone Sep 20, 2024
* Added note about fleetd 1.33 for better uninstall-on-failed-install handling
* Drop load balancer call-out for batch apply now that we handle that async
* Call out that software packages are managed by team, and add example use cases on why
* Misc. consistency/grammar fixes (incl. overlooked oblique references to security agents)
* Clarify side effects on package edit/remove
* Call out that when managing via GitOps the Fleet server, not the GitOps runner, is the one to pull packages, in case people need to set their firewalls accordingly
* Bump publish date since this is basically a fresh guide with URL backward compat
@iansltx
Copy link
Member

iansltx commented Sep 20, 2024

So, we have a few broken learn-more links. There are two in the article, and they're also referenced in the advanced package options dialog on edit software as of this release. There's also a broken learn-more-about link for EXE installers in particular.

Current plan:

  • Route install/uninstall script links to anchors for those items in the article
  • Add a callout on how install script variables work
  • Add a callout on how uninstall script variables work
  • Note that there's some nuance to EXE install/uninstall scripts, and link that to the learn-more anchor
  • Direct the EXE install scripts anchor to Default install script for .exe doesn't work in most cases #20000, as that's as good as anything for context.

The above is forward-compatible with dedicated articles/docs on these items, and provides sufficient information in the interim IMO.

ETA for all of the above is later this evening. Will ping when it's ready.

@iansltx
Copy link
Member

iansltx commented Sep 22, 2024

Found another broken learn-more-about link, so pointed that at this article as well. We probably want to revisit whether we have these links, and where they go to, but at least this way they don't 404.

@iansltx
Copy link
Member

iansltx commented Sep 23, 2024

Okay, now everything's ready, I think.

@iansltx
Copy link
Member

iansltx commented Sep 23, 2024

^ @spokanemac ping me if any of these edits don't make sense, given that there are a bunch of them.

@lukeheath lukeheath marked this pull request as ready for review September 23, 2024 21:19
@lukeheath lukeheath merged commit b9a5107 into main Sep 23, 2024
8 checks passed
@lukeheath lukeheath deleted the spokanemac-article-update-deploy-software branch September 23, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants