fleetdm.com/start: suggested copy change for fleetctl install #22251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
noahtalerman
commented
Sep 19, 2024
noahtalerman
commented
- Suggesting capital "Linux" and "macOS" b/c it feels more official.
- Suggesting capital "Linux" and "macOS" b/c it feels more official.
eashaw
reviewed
Sep 19, 2024
Comment on lines
-31
to
-32
| Linux*) OS='linux';; | ||
| Darwin*) OS='macos';; |
There was a problem hiding this comment.
@noahtalerman The OS variable is used to extract the archive containing fleetctl and needs to be lowercase. I'll add a commit to this PR that adds an OS_DISPLAY_NAME variable that will be used in messages printed for the user.
fleet-release
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.