Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Hide redundant built in label filtering #22308

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Sep 23, 2024

Issue

Cerra #21343

Description

  • Hides redundant built in label filtering if the built in label is a part of the dropdown
  • Clean up long label names awkwardly truncating much less wider than the dropdown space provided for the name

NOTE: We can't remove it for all labels as there's no other UI to get to edit/delete a custom label nor unclick a built in label that is not supported by the dropdown

Screenrecording

https://www.loom.com/share/5ec6b869f81140f1baed4186871e1bc6?sid=e79788df-9cdb-4e39-85ef-8734ae3f8e3f

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia merged commit 31ac408 into main Sep 24, 2024
14 checks passed
@RachelElysia RachelElysia deleted the 21343-redundant-labels-ui branch September 24, 2024 16:05
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.22%. Comparing base (b14f7fa) to head (911dc1c).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22308   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files        1496     1496           
  Lines      117247   117247           
  Branches     3563     3566    +3     
=======================================
  Hits        76474    76474           
  Misses      33636    33636           
  Partials     7137     7137           
Flag Coverage Δ
frontend 52.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants