Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Surface duplicate label name error to users #22389

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

RachelElysia
Copy link
Member

Issue

Cerra #21875

Description

  • Surface duplicate label name error to users on dynamic and manual label pages

Screenshot of fix

Screenshot 2024-09-25 at 8 58 13 AM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.22%. Comparing base (8428f19) to head (bb674cf).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22389   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files        1496     1496           
  Lines      117247   117247           
  Branches     3566     3573    +7     
=======================================
  Hits        76474    76474           
  Misses      33636    33636           
  Partials     7137     7137           
Flag Coverage Δ
frontend 52.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia merged commit 692e0fc into main Sep 25, 2024
14 checks passed
@RachelElysia RachelElysia deleted the 21875-duplicate-label-name branch September 25, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants