Remove homebrew app casks #24593
Remove homebrew app casks #24593
Conversation
mostlikelee
requested review from
rachaelshaw,
noahtalerman and
a team
as code owners
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
| path AS installed_path | ||
| FROM homebrew_packages | ||
| WHERE type = 'cask' | ||
| AND NOT EXISTS (SELECT 1 FROM file WHERE file.path LIKE CONCAT(homebrew_packages.path, '/%%%%', '/%%.app%%') LIMIT 1); |
There was a problem hiding this comment.
Double checking: LIKE with double %% (recursive search) on the file table can only be used at the end.
There was a problem hiding this comment.
Double wildcards can NEVER be used mid-string (infix)
https://blog.1password.com/the-file-table-osquerys-secret-weapon/
| path AS installed_path | ||
| FROM homebrew_packages | ||
| WHERE type = 'cask' | ||
| AND NOT EXISTS (SELECT 1 FROM file WHERE file.path LIKE CONCAT(homebrew_packages.path, '/%%%%', '/%%.app%%') LIMIT 1); |
There was a problem hiding this comment.
Am probably missing something, why not do CONCAT(homebrew_packages.path, '/%%%%/%%.app%%').
There was a problem hiding this comment.
If we cannot do the filtering cleanly and without performance impact on the device we could filter results server side.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24593 +/- ##
==========================================
+ Coverage 63.51% 63.53% +0.01%
==========================================
Files 1592 1592
Lines 151140 151184 +44
Branches 3885 3885
==========================================
+ Hits 95994 96048 +54
+ Misses 47492 47484 -8
+ Partials 7654 7652 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
#22944
Removing homebrew casks that install app bundles from the macos software detail query as they are already reported in the
appstable.appstable provides bundle_identifer which is used in vulnerability (CPE) matching to grab the correct vendor.changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.