Fleet UI: Add automatic install to custom packages upload #24729
+61
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24729 +/- ##
==========================================
- Coverage 63.55% 63.55% -0.01%
==========================================
Files 1601 1601
Lines 151668 151672 +4
Branches 3951 3952 +1
==========================================
- Hits 96398 96397 -1
- Misses 47595 47600 +5
Partials 7675 7675
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Error
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Error
RachelElysia
force-pushed
the
23344-custom-package
branch
from
5a73d41 to
1685063
Compare
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
commented
Dec 12, 2024
frontend/interfaces/software.ts
Outdated
| @@ -276,6 +277,7 @@ export interface ISoftwareInstallResult { | |||
| post_install_script_output: string; | |||
| created_at: string; | |||
| updated_at: string | null; | |||
| automatic_install: boolean; | |||
There was a problem hiding this comment.
@lucasmrod Will this return? or is it just for post
There was a problem hiding this comment.
Just for the POST. Because what makes the installer automated is the fact that it has a policy associated to it. The UI already renders the "Automatic install" using the automatic_install_policies field.
RachelElysia
commented
Dec 12, 2024
frontend/interfaces/software.ts
Outdated
| @@ -306,6 +308,7 @@ export interface ISoftwareInstallVersion { | |||
|
|
|||
| export interface IHostSoftwarePackage { | |||
| name: string; | |||
| automatic_install: boolean; | |||
There was a problem hiding this comment.
@lucasmrod Will this return? or is it just for post
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Story #23344
FE #24384
Description
Screenshots/screen recording
Tests updated
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.