Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSVL: Add labels to upload endpoint; add validations and related datastore methods #24733

Open
wants to merge 2 commits into
base: feat-labels-scoped-software
Choose a base branch
from
Open

SSVL: Add labels to upload endpoint; add validations and related datastore methods #24733

wants to merge 2 commits into from
+353 −15

Conversation

gillespi314
Copy link
Contributor

Part of #24535

@gillespi314 gillespi314 requested a review from a team as a code owner December 12, 2024 22:41
jahzielv
jahzielv reviewed Dec 13, 2024
View reviewed changes
server/fleet/labels.go
LabelScopeIncludeAll LabelScope = "include_all"
)

type LabelIndentsWithScope struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
type LabelIndentsWithScope struct {
type LabelIdentsWithScope struct {

@jahzielv
Copy link
Contributor

overall LGTM, just the nit + test issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahzielv jahzielv jahzielv left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gillespi314 @jahzielv