Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Determine query result column sort type from actual data present #24734

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Dec 12, 2024

Addresses #23011

  • In the same scan through results that the UI currently determines unique column names, determine which of thsoe columns can be sorted as alphanumeric.
Screenshot 2024-12-12 at 3 15 24 PM Screenshot 2024-12-12 at 3 14 25 PM
  • Changes file added for user-visible changes in changes/,
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.55%. Comparing base (ef9927a) to head (04c6357).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
.../components/QueryReport/QueryReportTableConfig.tsx 90.00% 1 Missing and 1 partial ⚠️
...etails/HostQueryReport/HQRTable/HQRTableConfig.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24734      +/-   ##
==========================================
- Coverage   63.55%   63.55%   -0.01%     
==========================================
  Files        1601     1601              
  Lines      151668   151663       -5     
  Branches     3862     3863       +1     
==========================================
- Hits        96398    96392       -6     
  Misses      47597    47597              
- Partials     7673     7674       +1     
Flag Coverage Δ
frontend 53.76% <92.10%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobshandling jacobshandling removed the request for review from a team December 13, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants