Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed potential deadlocks when deploying Apple configuration profiles. #24777

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed potential deadlocks when deploying Apple configuration profiles. #24777

wants to merge 5 commits into from
+142 −103

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Dec 13, 2024 •
edited
Loading

#24771

Fixing deadlocks found in loadtest: https://docs.google.com/document/d/1-Q6qFTd7CDm-lh7MVRgpNlNNJijk6JZ4KO49R1fp80U/edit?tab=t.0

  • added retries to statements prone to deadlocks

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

@getvictor getvictor marked this pull request as ready for review December 13, 2024 23:45
@getvictor getvictor requested a review from a team as a code owner December 13, 2024 23:45
gillespi314
gillespi314 reviewed Dec 14, 2024
View reviewed changes
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as an interim measure.

Assuming we end up deciding to drop the last_seen_at updates for the nano tables altogether, what are the downsides to keeping these retries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gillespi314 gillespi314 gillespi314 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getvictor @gillespi314