Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routes.js #25645

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Update routes.js #25645

merged 3 commits into from
Jan 23, 2025

Conversation

eugkuo
Copy link
Contributor

@eugkuo eugkuo commented Jan 21, 2025

Added redirect to https://fleetdm.com/guides/automatic-software-install-in-fleet#templates-for-policy-queries for information on how to reinstall apps. May update this with a different anchor link once updated text is live.

Added redirect to https://fleetdm.com/guides/automatic-software-install-in-fleet#templates-for-policy-queries for information on how to reinstall apps. May update this with a different anchor link once updated text is live.
website/config/routes.js Outdated Show resolved Hide resolved
@fleet-release fleet-release requested a review from eashaw January 22, 2025 00:19
Changed target to relative link

Co-authored-by: Eric <[email protected]>
@eugkuo
Copy link
Contributor Author

eugkuo commented Jan 22, 2025

@eashaw Updated link to relative link. Thanks for suggesting that. I saw that both were done in the past and I wasn't sure which to use. :-)

@iansltx
Copy link
Member

iansltx commented Jan 23, 2025

Couple quick notes:

  1. I missed this (sorry for the back-and-forth) because I didn't notice the PR was open. More descriptive title (e.g. Add redirect for information on how to reinstall apps) would help here. A PR will take the title of the commit it contains if it's only one commit, so if you tweak the commit message then the PR title will follow.
  2. You can branch off of other people's branches, including the branch for a PR, and then target that branch in the PR. Then when that PR is merged your PR will repoint to wherever that PR got merged into. That's helpful in cases like this where your work depends on Noah's, and Noah's actually targets the docs branch rather than main. Extra helpful in that case because we can stage both the docs updates and the redirect so they both go live at the same time (when the docs branch gets merged in as part of the 4.63 release).

lmk if the above git-fu would be more helpful in the form of a pairing session and we can do that :)

@eugkuo
Copy link
Contributor Author

eugkuo commented Jan 23, 2025

lmk if the above git-fu would be more helpful in the form of a pairing session and we can do that :)

@iansltx A pairing session would be 10000000% helpful :p

@eugkuo eugkuo merged commit ff43593 into main Jan 23, 2025
6 checks passed
@eugkuo eugkuo deleted the eugkuo-patch-3-reinstall-software-redirect branch January 23, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants