Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flet build --exclude command option #3125

Closed
BrentHuang opened this issue Apr 29, 2024 · 8 comments
Closed

Flet build --exclude command option #3125

BrentHuang opened this issue Apr 29, 2024 · 8 comments
Assignees
Labels
feature request Suggestion/Request for additional feature packaging Related to app packaging

Comments

@BrentHuang
Copy link

flet build does not have the exclude option and cannot exclude some directories or files.

@ndonkoHenri
Copy link
Contributor

Which directories do you wish to see excluded? Please provide more information.
Flet build packages only content of your project directory.

@ndonkoHenri ndonkoHenri added the status: awaiting response Further information is requested label Apr 29, 2024
@BrentHuang
Copy link
Author

BrentHuang commented Apr 29, 2024

For example, in my project, there is a logs directory, which contains log files, and a scripts directory, which contains my packaging scripts, which are not needed.

image

In the above picture, there are .po files in the translations directory, which also do not need to be packaged.

@InesaFitsner InesaFitsner added packaging Related to app packaging and removed status: awaiting response Further information is requested labels Apr 29, 2024
@FeodorFitsner
Copy link
Contributor

package command in serious_python package already has --exclude option, but I see flet build passes hard-coded assets,build there. We need to expose this option in flet build.

Another option would be "automate" exclusion list by parsing .gitignore. Don't know if other tools do that, but sounds like a nice idea :)

@FeodorFitsner FeodorFitsner added the feature request Suggestion/Request for additional feature label Apr 29, 2024
@BrentHuang
Copy link
Author

A semantically clear exclude is better.

@BrentHuang
Copy link
Author

A semantically clear exclude is better, because some files and directories may not necessarily be in .gitignore file.

@ndonkoHenri ndonkoHenri changed the title flet build does not have the exclude option and cannot exclude some directories or files. Flet build --exclude command option Apr 30, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Flet Development May 6, 2024
@BrentHuang
Copy link
Author

flet build --build-number=1 --build-version="1.0.0" --exclude="scripts/ logs/ .gitignore babel.cfg i18n.bat README.md requirements.txt .pod.po" -vv windows

flet 0.22.1 --exclude like this? but has no effect like this, no files and dirs excluded.

50Bytes-dev pushed a commit to 50Bytes-dev/flet that referenced this issue May 18, 2024
* Fix `flet --version` command for source checkout

* Fix message

* update `file_picker` to 8.0.3

* Added logo in png

* Added `--exclude` option to `flet build` command

Close flet-dev#3125

* Flet version bumped to 0.22.1

* Fixed: OAuth expiry of token will hang fastapi server

Fix flet-dev#3150

* Update changelog

* Make `dependency_overrides` optional

Fix flet-dev#3187

* Updated changelog
zrr1999 pushed a commit to zrr1999/flet that referenced this issue Jul 17, 2024
* Fix `flet --version` command for source checkout

* Fix message

* update `file_picker` to 8.0.3

* Added logo in png

* Added `--exclude` option to `flet build` command

Close flet-dev#3125

* Flet version bumped to 0.22.1

* Fixed: OAuth expiry of token will hang fastapi server

Fix flet-dev#3150

* Update changelog

* Make `dependency_overrides` optional

Fix flet-dev#3187

* Updated changelog
@MSchwesig
Copy link

MSchwesig commented Aug 9, 2024

flet build --build-number=1 --build-version="1.0.0" --exclude="scripts/ logs/ .gitignore babel.cfg i18n.bat README.md requirements.txt .pod.po" -vv windows

It works, you just have to separate differently:

  • no / at the end of a dir, just the name of the dir.
  • separate the files with a ,
  • pack all in "
    so it would be something like that:
    flet build --build-number=1 --build-version="1.0.0" --exclude="scripts, logs, .gitignore, babel.cfg, README.md" windows

and do not exclude the requirements.txt, you need the dependencies ;)

@syleishere
Copy link
Contributor

This is useful, adding wildcard support like *.bat, *.sh would be great addition to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggestion/Request for additional feature packaging Related to app packaging
Projects
None yet
Development

No branches or pull requests

6 participants