-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TextField.counter
property
#3676
Conversation
Reviewer's Guide by SourceryThis pull request implements the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 7 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Fixes #3656
Summary by Sourcery
This pull request adds a new
counter
property to theTextField
andDropdown
components, allowing for the display of a counter control. ThebuildInputDecoration
function has been updated to support this new property.counter
property to theTextField
andDropdown
components, allowing for the display of a counter control.buildInputDecoration
function to support the newcounter
property, enabling the inclusion of a counter control in the input decoration.