-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MapConfiguration.interaction_configuration
is not honoured
#3976
Conversation
Reviewer's Guide by SourceryThis pull request addresses an issue where the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Can you look at conflicts please? |
Hi, |
It works on my mac: import random
import flet as ft
import flet.map as map
def main(page: ft.Page):
page.add(
map.Map(
expand=True,
initial_center=map.MapLatitudeLongitude(15, 10),
initial_zoom=4.2,
interaction_configuration=map.MapInteractionConfiguration(flags=map.MapInteractiveFlag.NONE),
layers=[
map.TileLayer(
url_template="https://tile.openstreetmap.org/{z}/{x}/{y}.png",
on_image_error=lambda e: print("TileLayer Error"),
),
],
),
)
ft.app(main) Give the above a try. |
Hi ndonkoHenri, |
Yes it works too: interaction_configuration=map.MapInteractionConfiguration(flags=map.MapInteractiveFlag.ALL & ~map.MapInteractiveFlag.ROTATE) Will give it a try on my Windows when possible. Concerning the Flet app, we are working on updating it to support changes made in 0.25.0 |
Description
Fixes #3973
Summary by Sourcery
Fix the issue where
MapConfiguration.interaction_configuration
was not being honored by adding theinteractionOptions
toMapOptions
. Enhance the map functionality by introducing support for pointer hover events, allowing the map to trigger apointer_hover
event with latitude, longitude, and pointer details.Bug Fixes:
MapConfiguration.interaction_configuration
is correctly applied by adding theinteractionOptions
parameter toMapOptions
.Enhancements:
pointer_hover
event with relevant details.