Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong type (asyncio.Future -> concurrent.futures.Future) and handle CancelledError #4268

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

bl1nch
Copy link
Contributor

@bl1nch bl1nch commented Oct 31, 2024

Description

Fixes #4230 and handle CancelledError

Test Code

# Test code for the review of this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots (if applicable):

Additional details

Summary by Sourcery

Correct the type annotation in the run_task function and handle CancelledError exceptions to improve error handling.

Bug Fixes:

  • Fix the incorrect type annotation from asyncio.Future to concurrent.futures.Future in the run_task function.
  • Handle CancelledError exceptions gracefully in the run_task function.

@bl1nch bl1nch changed the title Fix wrong type (asyncio.Future -> concurrent.futures.Future) Fix wrong type (asyncio.Future -> concurrent.futures.Future) and handle CancelledError Oct 31, 2024
Co-authored-by: Christian Clauss <[email protected]>
@FeodorFitsner FeodorFitsner merged commit b5e05c3 into flet-dev:main Oct 31, 2024
2 checks passed
@bl1nch bl1nch deleted the patch branch November 13, 2024 02:25
@ndonkoHenri

This comment was marked as outdated.

This comment was marked as resolved.

@ndonkoHenri
Copy link
Contributor

@sourcery-ai review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants