Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in meshConservativeAdvancementOrientedNodeCanStop #271

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

geoynomous
Copy link
Contributor

@geoynomous geoynomous commented Mar 26, 2018

"1" is index of "y" coordinate


This change is Reviewable

@sherm1 sherm1 mentioned this pull request Mar 26, 2018
@sherm1
Copy link
Member

sherm1 commented Mar 26, 2018

:lgtm: -- looks like an obviously good fix to me! Any objections @jslee02 ? That was your TODO there I think.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sherm1
Copy link
Member

sherm1 commented Mar 26, 2018

+@sherm1 +@jslee02 (please lgtm if you're ok with this change)


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@sherm1 sherm1 self-assigned this Mar 26, 2018
@jslee02
Copy link
Member

jslee02 commented Mar 26, 2018

:lgtm: Yeah, I left that note, and this fix looks good to me!


Comments from Reviewable

@sherm1
Copy link
Member

sherm1 commented Mar 26, 2018

I verified that the CI failures are the usual Mac suspects and unrelated to this PR. Help, Mac people!

@sherm1 sherm1 merged commit 2b0f911 into flexible-collision-library:master Mar 26, 2018
@geoynomous geoynomous deleted the MotionIndexBug branch March 27, 2018 07:20
@geoynomous
Copy link
Contributor Author

@sherm1 I can test on a Mac - what is the "usual Mac suspects"?

@mamoll
Copy link
Member

mamoll commented Mar 27, 2018

Unit tests pass on my Mac, OS X 10.13.3, Xcode 9.2, Boost 1.66 and libccd 2.0 (the last two installed via MacPorts).

@sherm1
Copy link
Member

sherm1 commented Mar 27, 2018

@geoynomous: If you look at the Travis-CI Xcode 7.3 build failures here you'll see that the Debug build fails test test_fcl_capsule_box_1 and the Release build fails that test and also test_fcl_box_box.

We have yet to find a local Mac that reproduces those problems. Our experience here has been like @mamoll reported above -- everything works fine. Our working hypothesis is that there is just something wrong with the Mac compiler being used on Travis but since we can't reproduce the problem it's not very convincing. Issue #265 is tracking this problem. If you are willing to give this a try and report the results in #265, that would be great -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants