Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS code formatting problems solved #531

Merged
merged 7 commits into from
Jan 25, 2024
Merged

PHPCS code formatting problems solved #531

merged 7 commits into from
Jan 25, 2024

Conversation

fadrian06
Copy link
Contributor

No description provided.

@fadrian06 fadrian06 marked this pull request as ready for review January 25, 2024 07:49
@fadrian06 fadrian06 requested a review from n0nag0n January 25, 2024 07:50
Copy link
Collaborator

@n0nag0n n0nag0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I don't know why it beautified so differently for you than it did me unless you are forcing sublime to enforce coding standards outside of PSR12

@fadrian06
Copy link
Contributor Author

I have the EditorConfig plugin in Sublime That's why the LSP always respects the 4 spaces and replaces all the tabs that are left there.

@fadrian06
Copy link
Contributor Author

in the source code it does not automatically format unless you commit only the formatting...in this PR I did all the formatting by hand to reduce the size of the lines since phpcs complains about lines longer than 120 characters

@fadrian06
Copy link
Contributor Author

finally I applied phpcbf but it didn't do anything because almost everything was already formatted

@fadrian06 fadrian06 merged commit 9291d7a into master Jan 25, 2024
@fadrian06 fadrian06 deleted the code-format branch January 25, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants