Add sys::furi::Error type for kernel errors
#186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow-up to #183. |
JarvisCraft
approved these changes
Nov 5, 2024
This is an updated attempt at improving the ergonomics around working with `FuriStatus`. Rather than trying to use `sys::furi::Status` as a pseudo-`Error`/`Result` type, use a dedicated `Error` enum. In a future PR I'm going to change how the bindings for `enum FuriStatus` to a newtype rather than integer constant. This will remove the need for a seperate `sys::furi::Status` type and the associated hoops required to turn that into a `Result` type. Being an alias for `i32` limits what traits or functions can be implemented on the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated attempt at improving the ergonomics around working with
FuriStatus. Rather than trying to usesys::furi::Statusas a pseudo-Error/Resulttype, use a dedicatedErrorenum.In a future PR I'm going to change how the bindings for
enum FuriStatusto a newtype rather than integer constant. This will remove the need for a seperatesys::furi::Statustype and the associated hoops required to turn that into aResulttype. Being an alias fori32limits what traits or functions can be implemented on the type.