Pass executable for code style validator #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please word the commit message in Present Simple, like "Passes name of code style validator", the rest is 👍 |
|
@nikolaykasyanov Don't know why Travis fails. Could you restart the build? |
|
@robertodr it seems to be crashing on a specific Ruby version (2.3.1) |
|
@robertodr I'm checking if master is affected as well, and if yes, I'll try to deal with it. |
|
@robertodr I'll merge #11 as soon as build is ready, thereafter you can rebase on master. This should fix the issue. |
nikolaykasyanov
approved these changes
Sep 29, 2017
|
Cool, thanks! |
|
@robertodr here we go! |
|
Rebased! 😸 |
|
Thank you! I'll make a new release on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use
clang-format-3.9. Using the Trusty images on Travis, ships version 3.5 asclang-formatwhich generated some false positives for my project. I have added an additionalvalidatorparameter to prevent this. This could be a stepping stone to provide support for checkers othen thanclang-formatand for languages other than those covered byclang-format. I have other projects where I would like to use yapf for Python, for example. I aim at filing a PR later on for these additions.