-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlowFolder #90
base: master
Are you sure you want to change the base?
FlowFolder #90
Conversation
This looks like a big feature and well done, but I don't get the idea why it is needed. |
A Or the |
360bba6
to
b9e5421
Compare
Is this project dead or is the author ignoring any contributions? This is well over a year old and would be a really nice feature :( |
I am not sure we need this feature. This pull request contains so many code changes, it would require some decent testing. For now, only two people requested this, so it is a low priority. It would be better to have this as a plugin |
It would be nice to have this feature, i often need to send folder with a lot of files (more than 1000 files) and it's difficult to follow the upload status of all these files. Would there be a solution to create a new flow object dedicated to a folder? |
Currently I don't have time to merge this feature. I gave a quick peek and I think it needs some performance improvements. And what about angular? It might not be compatible. As @dolymood has mentioned, these changes can be moved to a separate plugin. I could merge it as a separate file. It does not need to be tested or to be perfect. |
Just one question a little bit off subject, I'm trying to see if I can create a second instance of the flow to dedicate it to a folder when it is detected by the first instance. import * as Flow from '@flowjs/flow.js'
const a = new Flow({...})
const b = new Flow({...})
b.custom_attribute = "test"
console.log(a.custom_attribute)
-> "test" |
When we upload a folder, may be we want to show the folder rather than the files in it.
So i created a new branch in https://github.com/dolymood/flow.js/tree/folder.I added
FlowFolder
constructor and theparsedFiles
property toFlow
object.Maybe it is a good idea.
Or support an option like
showFolder
in theFlow
options.