Skip to content

Commit

Permalink
fix(client-s3): getObject type was not exported correctly
Browse files Browse the repository at this point in the history
  • Loading branch information
godu committed Nov 21, 2024
1 parent ddc9212 commit 621b14b
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 15 deletions.
5 changes: 5 additions & 0 deletions .changeset/thirty-mangos-sparkle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect-aws/client-s3": patch
---

Type fix
31 changes: 16 additions & 15 deletions packages/client-s3/src/S3Service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,22 @@ const commands = {
interface S3Service$ {
readonly _: unique symbol;

/**
* @see {@link GetObjectCommand}
*/
getObject:
| ((
args: GetObjectCommandInput,
options?: { readonly presigned?: false } & HttpHandlerOptions,
) => Effect.Effect<
GetObjectCommandOutput,
SdkError | InvalidObjectStateError | NoSuchKeyError
>)
| ((
args: GetObjectCommandInput,
options?: { readonly presigned: true } & RequestPresigningArguments,
) => Effect.Effect<string, SdkError | S3ServiceError>);

/**
* @see {@link AbortMultipartUploadCommand}
*/
Expand Down Expand Up @@ -846,21 +862,6 @@ interface S3Service$ {
options?: HttpHandlerOptions,
): Effect.Effect<GetBucketWebsiteCommandOutput, SdkError | S3ServiceError>;

/**
* @see {@link GetObjectCommand}
*/
getObject(
args: GetObjectCommandInput,
options?: { readonly presigned?: false } & HttpHandlerOptions,
): Effect.Effect<
GetObjectCommandOutput,
SdkError | InvalidObjectStateError | NoSuchKeyError
>;
getObject(
args: GetObjectCommandInput,
options?: { readonly presigned: true } & RequestPresigningArguments,
): Effect.Effect<string, SdkError | S3ServiceError>;

/**
* @see {@link GetObjectAclCommand}
*/
Expand Down

0 comments on commit 621b14b

Please sign in to comment.