Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client-s3): getObject type was not exported correctly #84

Closed
wants to merge 1 commit into from
Closed

fix(client-s3): getObject type was not exported correctly #84

wants to merge 1 commit into from

Conversation

godu
Copy link
Contributor

@godu godu commented Nov 21, 2024 •
edited
Loading

Type generation omits the "getObject" method in the definition, probably due to the double type function definition

To reproduce

// KO
yield* S3Service.getObject({Bucket, Key});
// OK
const {getObject} = yield* S3Service;
getObject({Bucket, Key});

floydspace
floydspace reviewed Nov 24, 2024
View reviewed changes
Copy link
Owner

@floydspace floydspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is good finding @godu
however I have to decline your PR
here is the proper fix: a17e239

@floydspace floydspace closed this Nov 24, 2024
@godu godu deleted the fix/client-s3-get-object-type-generation branch November 25, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floydspace floydspace floydspace left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godu @floydspace