Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For #3649] Fix timeout handling #3686

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Mar 24, 2022

Which issue(s) this PR fixes:
This is about #3609.
Fix timeout handling for #3649.

What this PR does / why we need it:
The current limit? usage is complicated, so I have tried to make it simple.

Docs Changes:
None.

Release Note:
None.

Add 2 states to control timeout.

Signed-off-by: Daijiro Fukuda <[email protected]>
lib/fluent/plugin_helper/retry_state.rb Outdated Show resolved Hide resolved
lib/fluent/plugin_helper/retry_state.rb Outdated Show resolved Hide resolved
Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom
Copy link
Contributor Author

daipom commented Mar 24, 2022

Thanks for the review. I have reshaped codes, and confirmed the following success again.

  • $ bundle exec rake test TESTOPTS="-t'BufferedOutputRetryTest'"
  • $ bundle exec rake test TESTOPTS="-t'RetryStateHelperTest'"

@ashie ashie merged commit e3f5034 into fluent:issue-3609-2 Mar 24, 2022
@ashie
Copy link
Member

ashie commented Mar 24, 2022

Thanks!

@ashie ashie added this to the v1.14.6 milestone Mar 30, 2022
@daipom daipom deleted the issue-3609-2-fukuda branch December 28, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants