winsvc: require serverengine #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #3849, getting ruby's path was replaced with `ServerEngine.ruby_bin_path` but `require 'serverengine'` was missing. As a result it fails to launch fluentd service. Signed-off-by: Takuro Ashie <[email protected]>
cosmo0920
approved these changes
Aug 22, 2022
|
BTW, can we add register/unregister e2e test on CI task? If not possible for now, testing manually is also OK for us. |
|
I think at least |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Follow up for #3849
What this PR does / why we need it:
In #3849, getting ruby's path was replaced with
ServerEngine.ruby_bin_pathbutrequire 'serverengine'was missing.As a result it fails to launch fluentd service.
Docs Changes:
None
Release Note:
None (Same with #3849)